Module talk:WikiProject banner

Template:Etymology section

Template uses custom code to implement a custom quality rating, but it does not do it in the usual way with a custom mask. I'm not sure what to do with this template so dropping it here in case others have an idea. — Martin (MSGJ · talk) 23:15, 23 February 2024 (UTC)

@Kanashimi, @Qwerfjkl: please could you not remove any class parameter from this template until we figure out the best way to code it? It is using a custom mask, but not in the usual way. — Martin (MSGJ · talk) 20:56, 2 March 2024 (UTC)

Martin, I've stopped my bot, it's run on the vast majority of pages. — Qwerfjkltalk 20:58, 2 March 2024 (UTC)

Okay, wow. I didn't realise you had already finished! — Martin (MSGJ · talk) 20:59, 2 March 2024 (UTC)

Martin, yes, we've totally emptied the main two categories (in the main talk namepace). Around 4-5 million pages, I think. — Qwerfjkltalk 21:01, 2 March 2024 (UTC)

Yes, we've already processed a round of major categories. But I'm still on the task of removing obsolete parameters. I suggest adding {{Etymology section}} to Category:WikiProjects using a non-standard quality scale first. Kanashimi (talk) 22:53, 2 March 2024 (UTC)

How is that template not appearing in Category:WikiProject banners with non-standard names? Gonnym (talk) 13:33, 3 March 2024 (UTC)

The current logic is (args.PROJECT_NAME=='WikiProject '..project or not args.PROJECT_NAME) and current_page.rootPageTitle.prefixedText~='Template:WikiProject ' .. project In this case the project name is not WikiProject PROJECT and it is not undefined — Martin (MSGJ · talk) 13:56, 3 March 2024 (UTC)

Maybe adjust this so we check either if |PROJECT_NAME= is equal to "WikiProject project" OR the template name does not start with "WikiProject"? Since we standardized on "WikiProject project" for these templates, there really shouldn't be many with non-standard valid names I think, unless I missed something. Gonnym (talk) 15:23, 3 March 2024 (UTC)

This banner isn't for a WikiProject. Perhaps that issue should be corrected instead? Izno (talk) 17:53, 3 March 2024 (UTC)

Isn't it part of linguistics project? — Martin (MSGJ · talk) 19:22, 3 March 2024 (UTC)

A task force of that project, yes. Izno (talk) 22:11, 3 March 2024 (UTC)

I usually nominate task force banners to merge with their project banner but because this had manual code in it I left it alone for now as I didn't investigate what that code does and if indeed it needs manual code. Gonnym (talk) 06:52, 4 March 2024 (UTC)

I think I'll start by removing the custom code and attempting to use the standard methods. If that works then we can look at the next step — Martin (MSGJ · talk) 18:31, 4 March 2024 (UTC)

Conclusion: it is easy to convert it, but some categories would need to be renamed. Test cases at Template:Etymology section/testcases. I have also dropped a note on Wikipedia talk:WikiProject Linguistics. Also, there are only 142 pages using this template so it was never really adopted on any scale — Martin (MSGJ · talk) 18:47, 4 March 2024 (UTC)

Maybe after merging with {{WikiProject Linguistics}}, the syntax can be changed to something similar to this:

• {{WikiProject Linguistics|etymology=yes|etymology-section=good}}
• {{WikiProject Linguistics|etymology=yes|etymology-section=incomplete}}
• {{WikiProject Linguistics|etymology=yes|etymology-section=missing}}
• {{WikiProject Linguistics|etymology=yes|etymology-section=unassessed}}

so instead of a new set of unique classes, it will just be another parameter that will trigger the placement in the category. Gonnym (talk) 10:02, 6 March 2024 (UTC)

Sounds like a good plan. I also think we could rename Category:Articles with mid-importance etymologies to Category:Mid-importance etymology articles or similar — Martin (MSGJ · talk) 10:30, 6 March 2024 (UTC)

I feel like those are just other ways to grade each article with a class, which we have examples of for task forces. Good would put it in B, incomplete C or start, unassessed is missing a grade, and missing is probably equivalent to unassessed ultimately... Izno (talk) 17:17, 6 March 2024 (UTC)

That's also a good point. Gonnym (talk) 07:19, 7 March 2024 (UTC)

Missing etymology might just be like |needs-infobox= I guess, but the rest all have direct analogs to our rating system. Izno (talk) 16:32, 7 March 2024 (UTC)

Due to the lack of any response at the project talk page, it seems no one is interested in this template, so I have just removed the non-standard assessments altogether. If this gets reverted then we can look at methods to preserve the assessments in a more standard way — Martin (MSGJ · talk) 09:15, 3 April 2024 (UTC)

Execution time

I've recently been looking into the execution time of this module due to a couple of lua timeout errors occassionally popping up on larger pages with a lot of banner templates (e.g. 1, 2, 3 (not entirely wpb's fault)). I've already proposed a change to a module this module uses which should solve the issue well enough, but I think it's still worth looking into optimising this code.

I've noticed that this module can call Pagetype (which is intensive in comparison to most things required) on the same page up to (but not always) 3 times while handling a banner (see lines 161, 299, and 327). Considering 2 of them are caused by calling class_mask (definitely a duplicate pagetype call we don't need to make), I feel like it should be possible to reduce the max calls to 2, but the functionality of some of this module is beyond me (no clue what FQS means to start with), so I'm not confident I could optimise this myself without breaking some sort of functionality. Could someone consider taking a look at this? Aidan9382 _(talk) 22:16, 21 March 2024 (UTC)

I guess it should be possible to reduce the calls to pagetype to 1. I'll have a look when I get a chance — Martin (MSGJ · talk) 22:38, 21 March 2024 (UTC)

Okay please have a look at my changes in the sandbox. There would need to be a minor change to Module:Banner shell at the same time — Martin (MSGJ · talk) 12:32, 22 March 2024 (UTC)

No comment on functionality, but I imagine there are testcases for this module in terms of that (though unless there was some sort of super specific scenario where the main function specifically but not the class mask wanted to ignore disambiguation, I doubt anything is broken). Thanks to this change and a change in a different module, the sandbox version is now running about 6.5 times faster than the live version in the worst case scenario (significantly large pages, all 3 pagetype calls - I'm using Talk:List of common misconceptions for my testcases), which is a huge improvement, so thanks for doing that. I'd recommend updating banner shell before this module whenever that happens so there isn't a small window where stuff breaks. Aidan9382 _(talk) 17:04, 22 March 2024 (UTC)

Great. I've implemeneted your changes to pagetype. I will have a look to see if any other changes are needed to banner shell and then probably do that one later today. Can I ask how you came across Talk:List of common misconceptions and discovered the issue? By the way, when we have resolved all the conflicting article ratings, I hope we will be able to improve efficiency by just doing the quality assessment once (on the banner shell) rather than having to it on each individual banner — Martin (MSGJ · talk) 19:30, 22 March 2024 (UTC)

I came across that talk page since my bot, which handles bad archive values in {{User:MiszaBot/config}} as one of its tasks, kept throwing warnings for pages that had appeared in a tracking category despite having what it (correctly) thought was the already right input (you can see the result of me purging some of the pages to temporarily remove the timeout in Special:Diff/1214818416). I just removed templates and used show preview till I found what was responsible for the majority of the execution time, which is why I've been improving the execution time of multiple modules recently. Aidan9382 _(talk) 19:39, 22 March 2024 (UTC)

New code deployed, so hopefully that reduces the lag on these pages — Martin (MSGJ · talk) 21:06, 24 March 2024 (UTC)

Thanks, stuff's looking much better now (not even 2s on the misconceptions page compared to over 6s before the updates). Aidan9382 _(talk) 21:28, 24 March 2024 (UTC)

Documentation

There is a piece of automatically generated documentation on Template:WikiProject Military history that says "This project has opted out of project-independent quality assessments and is using a custom class mask." The Project has not opted out of project-independent quality assessments. Can we delete "has opted out of project-independent quality assessments"? I am unsure where this is done. Hawkeye7 (discuss) 00:07, 1 April 2024 (UTC)

The military history project has opted out of PIQA. That is the only way to support the custom quality scale. — Martin (MSGJ · talk) 09:10, 1 April 2024 (UTC)

What would be the effect of adopting the PIQA? Hawkeye7 (discuss) 17:43, 1 April 2024 (UTC)

Losing all the custom logic in Template:WikiProject Military history/class — Martin (MSGJ · talk) 09:09, 3 April 2024 (UTC)

Does that include the A-class logic or just the B-class logic? Hawkeye7 (discuss) 18:12, 3 April 2024 (UTC)

You'd certainly lose AL, BL and CL, probably several of the others; you might be left with just the standard scale (FA, A, GA, B, C, Start, Stub, FL, List). --Redrose64 🌹 (talk) 19:01, 3 April 2024 (UTC)

PROJECT_STATUS parameter

The module currently has an undocumented parameter for the status of a project, which will add a CSS class to the outer table. For example if you set |PROJECT_STATUS=semiactive then it will add class="semi-active-project". Does anyone know if this has any purpose or is used by any tools? It either needs documenting properly or removing — Martin (MSGJ · talk) 11:53, 24 April 2024 (UTC)

The rendering of the banner changes also, see uses. Izno (talk) 16:45, 25 April 2024 (UTC)

The rendering of inactive banners is not triggered by the PROJECT_STATUS parameter. It's produced by a different ("inactive") function of the module — Martin (MSGJ · talk) 08:58, 26 April 2024 (UTC)

This parameter was added in 2021 after this request by User:MJL. The rationale given was "The change adds a new class to the banner which would allow users to hide inactive WikiProject at their own discretion". — Martin (MSGJ · talk) 09:01, 26 April 2024 (UTC)

Here are my thoughts:

• It is understandable that some editors wish to hide inactive banners, and the inactive-project class should continue to be applied to inactive banners.
• I do not see the value of active-project or semi-active-project and I don't believe anyone is using these.
• The |PROJECT_STATUS= parameter can be dropped from active project banners
• For inactive banners, there may be some utility in allowing |PROJECT_STATUS=defunct to be defined instead of the default |PROJECT_STATUS=inactive. So this parameter should continue to be supported for inactive banners.
• Other statuses listed at Wikipedia:Inactive WikiProjects such as "dormant", "revivable", "dead", "stillborn" will not be supported unless there is a specific request for this.

— Martin (MSGJ · talk) 11:16, 29 April 2024 (UTC)

@MSGJ: I'd agree with what you've laid out there. –MJL ‐Talk‐^☖ 18:30, 29 April 2024 (UTC)

Out of interest, did you use personal CSS to hide these banners, or are you aware of users who have done so? — Martin (MSGJ · talk) 20:27, 29 April 2024 (UTC)

 Done — Martin (MSGJ · talk) 11:20, 9 May 2024 (UTC)

Deletion of Template:WPBannerMeta/taskforce caused a table error at Template:WPBannerMeta/hooks/taskforces/taskforce

Deletion of {{WPBannerMeta/taskforce}} has caused a table error at {{WPBannerMeta/hooks/taskforces/taskforce}}. I don't know what was in that deleted page, so I don't know what to insert into the latter page's noinclude tags to work around this error. – Jonesey95 (talk) 13:33, 26 April 2024 (UTC)

It wasn't being used, so I have deleted it under G8 — Martin (MSGJ · talk) 13:54, 26 April 2024 (UTC)

It looks like {{WPBannerMeta/hooks/taskforces/templatepage}} may also have become unused and deleteable. – Jonesey95 (talk) 14:32, 27 April 2024 (UTC)

I believe it is only Template:WikiProject Indian roads, Template:WikiProject U.S. Roads and possibly some other roads projects that are using this depcrecated code now — Martin (MSGJ · talk) 14:22, 30 April 2024 (UTC)

Classifying subpages in main talk

Moved to Template talk:Pagetype

All pages not in article space are automatically detected as being non-articles. But Gonnym pointed out that we have some subpages in Main talk space (e.g. Talk:Multiverse (Marvel Cinematic Universe)/FAQ) which should also be classified as non-articles. The types I have seen are FAQ pages like the above, or talk archive pages. It is not clear how we should classify them (e.g. Project-class) or just use the default NA-class for these types of page. Does anyone have any opinion? — Martin (MSGJ · talk) 17:50, 6 May 2024 (UTC)

I'd say that talk archive can be NA like regular talk. /FAQ (and maybe /GA) ideally should be project but if that is an issue then NA can work also (or allow manual override with the normal class parameter). Gonnym (talk) 08:15, 7 May 2024 (UTC)

I think I would prefer to treat all these subpages in the same way, rather that try to guess what they are based on the name of the page — Martin (MSGJ · talk) 11:10, 7 May 2024 (UTC)