happy.melon.wiki wrote:

Can you confirm whether this still occurs in trunk? The blocking system has been completely rewritten since 1.15.

Nx.devnull wrote:

It's slightly better in that it displays the message "The modification you tried to make was aborted by an extension hook." instead of <hookabort>, but it still doesn't allow the extension to customize that message, instead the extension's error message is outputted at the top and the title of the page changes to "internal error".

Nx.devnull wrote:

Quick and dirty hack

Here's a patch to show you a rough idea of what I'd like. Instead of returning a string, the extension can set the third parameter of the blockip hook and return false. The problem with this patch though is that it requires error to be a message key.

Attached:

Nx.devnull wrote:

And the extension to test this:

<?php

if ( !defined( 'MEDIAWIKI' ) ) {

exit;

}

$wgHooks['BlockIp'][] = 'BlockIpTest';

$wgExtensionMessagesFiles['PageList'] = dirname( FILE ) . '/blocktest.i18n.php';

function BlockIpTest( &$ban, &$user, &$error ) {

$error = 'test-abort';
return false;

}

and blocktest.i18n.php is:

<?php

$messages = array();

$messages['en'] = array(
'test-abort' => 'Testing block abort',
);